Skip to content

Use String.isBlank().#992

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Isira-Seneviratne:String_isBlank
Nov 30, 2022
Merged

Use String.isBlank().#992
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Isira-Seneviratne:String_isBlank

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member


Use String's isBlank() method, introduced in Java 11.

@TobiGr TobiGr merged commit 41c8dce into TeamNewPipe:dev Nov 30, 2022
@AudricV
Copy link
Copy Markdown
Member

AudricV commented Dec 24, 2022

I think we merged this PR too fast... This method doesn't exist on Android until API 33 and is not available with desugarging!

@Isira-Seneviratne
Copy link
Copy Markdown
Member Author

I think we merged this PR too fast... This method doesn't exist on Android until API 33 and is not available with desugarging!

I checked it on my end first, and the method gets desugared.

@AudricV
Copy link
Copy Markdown
Member

AudricV commented Dec 25, 2022

I didn't find anything about desugarging of this method. Do you have any source?

@Isira-Seneviratne
Copy link
Copy Markdown
Member Author

Isira-Seneviratne commented Dec 25, 2022

I didn't find anything about desugarging of this method. Do you have any source?

I built and decompiled the app, and there was a backport class for the method.

@Isira-Seneviratne Isira-Seneviratne deleted the String_isBlank branch January 1, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants