[YouTube] Return mqdefault thumbnails in fast feed#927
[YouTube] Return mqdefault thumbnails in fast feed#927Stypox merged 1 commit intoTeamNewPipe:devfrom
Conversation
1b0b8a0 to
289e422
Compare
The hqdefault thumbnails, which are used by default, have black bars at the top and at the bottom, and are thus not optimal.
289e422 to
93ef73e
Compare
|
"mq" sounds like "medium quality". Is that the case? If so, do we want to lower the resolution like that? Also, will this still be needed after Audric's image PR? |
|
See the discussion on IRC. The answers are: yes, yes and yes. It is better to have a medium quality thumbnail without black bars than a high quality one with black bars. Also, this is a change just to the fast feed extractor, for which it is expected that some information might be missing, so we should try our best to get the most out of the information we can (the black bars look very ugly). This will still be needed after AudricV's PR since this PR does not extract a new type of image URL, but rather generates such URL (which is something AudricV's PR doesn't do with youtube (and it is the right thing to do, generally)). |
|
I'm merging this for now. If there are better solutions in the future, it's not difficult to revert this small PR. |
The
hqdefaultthumbnails, which are returned by default by the fast feed extractor, have black bars at the top and at the bottom, and are thus not optimal. So this PR just replaceshqdefaultwithmqdefault: it seems to work well without issues after some testing, and unlikehighresdefaultthemqdefaultthumbnail always exists according to this SO. This fixes the problem with black bands in NewPipe: TeamNewPipe/NewPipe#8890 (comment)Debug apk: app-debug.zip
Both me (Stypox) and a user tested the apk and it works. All thumbnails load.