[YouTube] Use correct order of clients to get Android streams first#841
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Apr 28, 2022
Merged
Conversation
… adding more parameters to InnerTube requests, using the iOS client for livestreams and more
Stypox
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #780 (comment), I didn't noticed when applying the requested change, that by using a
HashMap, the order ofstreamingDataJSON objects wanted will be not respected (because in aMap, values are not ordered). This PR fixes this unwanted change, by using anArrayListinstead of aHashMap.Because we need to get at the same time the content playback nonce of a client and its corresponding
streamingDataJSON object andLists can contain only type of an element, I copied thePairclass of #810 and used it in my fix.To test the fix: get streams of a non age-restricted YouTube video (either audio or video), and check if most of streaming URLs contains
&c=ANDROID, instead of&c=WEB.