Extract stream segments for YouTube#479
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom Dec 19, 2020
Merged
Conversation
TobiGr
reviewed
Dec 11, 2020
TobiGr
reviewed
Dec 11, 2020
Collaborator
|
Nice! Maybe there is a way to integrate this into the background player as well. |
34642c2 to
9a7a224
Compare
Contributor
Author
|
I've updated the commits by using I'll update the test apk shortly. |
TobiGr
reviewed
Dec 12, 2020
Contributor
TobiGr
left a comment
There was a problem hiding this comment.
Thanks. That looks better now!
TobiGr
approved these changes
Dec 19, 2020
This was referenced Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the stream segments data provided by YouTube and makes them accessible inside
StreamInfo. Other services which don't support this data return an empty list when trying getting them. This also applies to streams in YouTube which aren't divided by the uploader.The added data class
StreamSegmentcontains the following data:String title: Title of the chapter set by the uploaderint startTimeSeconds: Starting point of the chapter in secondsString url: Direct link to the segment (...?t=)String previewUrl: Url to the image at the start positionTest against NewPipe
Demo video in NewPipe's player: https://streamable.com/e/3e27wa
Debug app: app-debug-segments-20201212.zip