Introduce Image class and provide all available images#268
Closed
wb9688 wants to merge 8 commits intoTeamNewPipe:devfrom
wb9688:image
Closed
Introduce Image class and provide all available images#268wb9688 wants to merge 8 commits intoTeamNewPipe:devfrom wb9688:image
wb9688 wants to merge 8 commits intoTeamNewPipe:devfrom
wb9688:image
Conversation
TobiGr
reviewed
Mar 1, 2020
Member
Author
|
@mauriciocolli and @TobiGr: Could you review this PR (except for the tests)? |
TobiGr
reviewed
Mar 3, 2020
Contributor
TobiGr
left a comment
There was a problem hiding this comment.
I don't have time for deep reviews now. I'll take a closer look at the structure at the weekend
Collaborator
|
For youtube stream thumbnails we could use the fact that the images urls are following a set schema describe here: https://stackoverflow.com/a/2068371 Example:
|
5 tasks
3 tasks
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TeamNewPipe/NewPipe#3121.
This PR will introduce an Image class, so that NewPipeExtractor will also return the width and height of an image, which NewPipe could use to determine which image to load. It'll also provide a list of all available images (i.e. different resolutions), but that's not implemented yet. Also, currebtly I've only implemented getting the actual width and height of the image for YouTube, I still have to look into the other services.
@TobiGr: Don't merge this for v0.18.6 though, this will be for v0.19.0 (or whatever we end up calling the next proper non-hotfix release).