Skip to content

Add Invidious instances#182

Merged
TobiGr merged 4 commits intoTeamNewPipe:devfrom
2secslater:patch-1
Sep 12, 2019
Merged

Add Invidious instances#182
TobiGr merged 4 commits intoTeamNewPipe:devfrom
2secslater:patch-1

Conversation

@2secslater
Copy link
Copy Markdown
Contributor

Added all publicly listed Invidious instances from omarroth/invidious wiki page to the link handler factory for YouTube.

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

Added all publicly listed Invidious instances from omarroth/invidious wiki page to the link handler factory for YouTube.
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one small, but important thing missing which prevents NewPipe Extractor recognizing Invidious instances. Please update


Otherwise your changes will have no impact and the app can not open links any URLs from instances.

theScrabi
theScrabi previously approved these changes Sep 10, 2019
@theScrabi theScrabi dismissed their stale review September 10, 2019 11:33

because i didn't look well enough

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Sep 10, 2019

Hm...
I can now open the videos, but I get a warning:

throw new ParsingException("Malformed unacceptable url: " + url);

Can you please try to track it down?
Full stacktrace

org.schabi.newpipe.debug E/class org.schabi.newpipe.report.ErrorActivity: org.schabi.newpipe.extractor.exceptions.ParsingException: Malformed unacceptable url: https://invidious.snopyta.org/watch?v=CYwrlXC9MT4
        at org.schabi.newpipe.extractor.linkhandler.LinkHandlerFactory.fromUrl(LinkHandlerFactory.java:43)
        at org.schabi.newpipe.extractor.linkhandler.ListLinkHandlerFactory.fromUrl(ListLinkHandlerFactory.java:27)
        at org.schabi.newpipe.extractor.StreamingService.getCommentsExtractor(StreamingService.java:296)
        at org.schabi.newpipe.extractor.comments.CommentsInfo.getInfo(CommentsInfo.java:25)
        at org.schabi.newpipe.util.ExtractorHelper.lambda$getCommentsInfo$6(ExtractorHelper.java:139)
        at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$4SXML3L5j2DhMfS2ZK06RZb2iyE.call(lambda)
        at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
        at io.reactivex.Maybe.subscribe(Maybe.java:4154)
        at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
        at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
        at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
        at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
        at io.reactivex.Flowable.subscribe(Flowable.java:14479)
        at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
        at io.reactivex.Maybe.subscribe(Maybe.java:4154)
        at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
        at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
        at java.lang.Thread.run(Thread.java:841)

@2secslater
Copy link
Copy Markdown
Contributor Author

what URL did you try to open?

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Sep 12, 2019

I get the error regardless which instance I use... But I just recognized this happens when using invidio.us, too. We can fix this in a different pull request as it is not caused by your changes.

@TobiGr TobiGr merged commit bfa6b4d into TeamNewPipe:dev Sep 12, 2019
evermind-zz added a commit to evermind-zz/NewPipeExtractor that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants