[YouTube] Fix serialization of Videos channel tab when it is already fetched#1222
Merged
AudricV merged 1 commit intoTeamNewPipe:devfrom Sep 29, 2024
Conversation
Stypox
approved these changes
Sep 16, 2024
Member
Stypox
left a comment
There was a problem hiding this comment.
Nice catch! I can't really reproduce the crash on NewPipe, but it totally makes sense that it might happen. Thank you for noticing and fixing!
422df70 to
597eaee
Compare
Also remove usage of Optional as fields as it is not a good practice. This simplifies in some places channel info extraction code.
597eaee to
42c1afa
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the ability to serialize
ReadyChannelTabListLinkHandlers for YouTube channels. It was due to the usage of thechannelHeaderfield ofYoutubeChannelExtractor, as explained in TeamNewPipe/NewPipe#11356 (comment). Even if this usage has been removed by copying the instance members into a new object, theChannelHeaderclass ofYoutubeChannelHelperwas not serializable, so crashes would still happen if I didn't make this class serializable.Optionalas fields and parameters of methods have been removed in the related extractor code as it is not a good practice. This simplifies in some places channel info extraction code.This PR and the issue it fixes also raise the question of the limits of the serialization system we use, both in the app and in the extractor.
Debug NewPipe APK based on app commit
035c394cf6704c0af9077c01ebfa55b810d02140with changes from commit 422df70: app-debug.zipFixes TeamNewPipe/NewPipe#11356.