[YouTube] fix: handle new like count viewModel#1123
Closed
Theta-Dev wants to merge 1 commit intoTeamNewPipe:devfrom
Closed
[YouTube] fix: handle new like count viewModel#1123Theta-Dev wants to merge 1 commit intoTeamNewPipe:devfrom
Theta-Dev wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
2 tasks
Member
|
Closing in favor of #1127, which I wanted to open before you opened your PR. I think my PR should fix the issue in a better way than yours, what do think? Anyway, thank you for your pull request and your time. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YouTube introduced a new view model for the like count on video pages (
nextendpoint). It currently appears in less than 1% of requests but that will probably change.The data structure looks like this (lots of fields omitted):
{ "segmentedLikeDislikeButtonViewModel": { "likeButtonViewModel": { "likeButtonViewModel": { "toggleButtonViewModel": { "toggleButtonViewModel": { "defaultButtonViewModel": { "buttonViewModel": { "iconName": "LIKE", "title": "4.2M", "accessibilityText": "like this video along with 4,209,059 other people" } } } } } } } }Visitor data cookie for testing:
CgtmV2MtdUFRRjJ6byib7Z6qBjIICgJERRICEgA%3D