Skip to content

[Bandcamp] Fix StreamExtractorTest #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 1 commit into from
Sep 17, 2023
Merged

[Bandcamp] Fix StreamExtractorTest #1105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...test/java/org/schabi/newpipe/extractor/services/bandcamp/BandcampStreamExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static void setUp() throws ExtractionException, IOException {
NewPipe.init(DownloaderTestImpl.getInstance());

extractor = (BandcampStreamExtractor) Bandcamp
.getStreamExtractor("https://teaganbear.bandcamp.com/track/just-for-the-halibut-creative-commons-attribution");
.getStreamExtractor("https://teaganbear.bandcamp.com/track/just-for-the-halibut");
extractor.fetchPage();
}

Expand All @@ -50,22 +50,22 @@ public StreamingService expectedService() {

@Override
public String expectedName() {
return "Just for the Halibut [Creative Commons: Attribution]";
return "Just for the Halibut";
}

@Override
public String expectedId() {
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut-creative-commons-attribution";
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut";
}

@Override
public String expectedUrlContains() {
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut-creative-commons-attribution";
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut";
}

@Override
public String expectedOriginalUrlContains() {
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut-creative-commons-attribution";
return "https://teaganbear.bandcamp.com/track/just-for-the-halibut";
}

@Override
Expand Down Expand Up @@ -157,7 +157,7 @@ void testArtistProfilePictures() {
void testTranslateIdsToUrl() throws ParsingException {
// To add tests: look at website's source, search for `band_id` and `item_id`
assertEquals(
"https://teaganbear.bandcamp.com/track/just-for-the-halibut-creative-commons-attribution",
"https://teaganbear.bandcamp.com/track/just-for-the-halibut",
BandcampExtractorHelper.getStreamUrlFromIds(3877364987L, 3486455278L, "track")
);
}
Expand Down