Skip to content

[YouTube] Don't throw an exception when there is no banner available on a channel #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 2 commits into from
Aug 2, 2023
Merged

[YouTube] Don't throw an exception when there is no banner available on a channel #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1fa84b
[YouTube] Don't throw an exception when there is no banner available …
AudricV Aug 1, 2023
bb1ab16
[YouTube] Test that no banner is returned for carouselHeaderRenders
AudricV Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ava/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeChannelExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,10 @@ public String getBannerUrl() throws ParsingException {
))
.filter(url -> !url.contains("s.ytimg.com") && !url.contains("default_banner"))
.map(YoutubeParsingHelper::fixThumbnailUrl)
.orElseThrow(() -> new ParsingException("Could not get banner"));
// Channels may not have a banner, so no exception should be thrown if no banner is
// found
// Return null in this case
.orElse(null);
}

@Override
Expand Down
4 changes: 3 additions & 1 deletion .../test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
Expand Down Expand Up @@ -720,7 +721,8 @@ public void testAvatarUrl() throws Exception {

@Test
public void testBannerUrl() throws Exception {
// CarouselHeaderRender does not contain a banner
// CarouselHeaderRenders do not contain a banner
assertNull(extractor.getBannerUrl());
}

@Test
Expand Down