Add track types to audio streams#1041
Merged
AudricV merged 8 commits intoTeamNewPipe:devfrom Mar 27, 2023
Merged
Conversation
AudricV
previously requested changes
Mar 19, 2023
Contributor
Author
|
Alright, I have fixed the issues. |
e22c116 to
1aa2324
Compare
FireMasterK
reviewed
Mar 20, 2023
FireMasterK
reviewed
Mar 20, 2023
FireMasterK
approved these changes
Mar 20, 2023
Member
FireMasterK
left a comment
There was a problem hiding this comment.
I think it looks great for the most part!
AudricV
requested changes
Mar 20, 2023
Member
AudricV
left a comment
There was a problem hiding this comment.
Almost good, you only have some small changes remaining (the ones below + the ones of FireMasterK). Thanks again!
2 tasks
FireMasterK
reviewed
Mar 21, 2023
…utubeParsingHelperTest
AudricV
approved these changes
Mar 27, 2023
Member
AudricV
left a comment
There was a problem hiding this comment.
I just pushed a commit removing unused imports, public method modifiers and the IP you used to generate stream URLs in YoutubeParsingHelperTest, which were the remaining changes that were needed to be done for me.
The commits of this PR will be squashed and merged to avoid unneeded mocks additions and deletions to the Git repository.
Thanks again!
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> Add support for multiple audio tracks NewPipe#9937
I replaced the
descriptiveAudioproperty of streams added by #1026 with the enum propertyaudioTrackType.The reason for this is that YouTube supports multiple types of audio streams. The ones that I have encountered are:
acont=original)acont=dubbed)acont=descriptive)The new property allows creating unique, localized names for every audio track without relying on the
trackNamewhich is always fetched in English.