Skip to content

[Bandcamp] Show comments as disabled on radio streams#1031

Merged
fynngodau merged 1 commit intoTeamNewPipe:devfrom
petlyh:bandcamp-fix-radio-comments
Feb 27, 2023
Merged

[Bandcamp] Show comments as disabled on radio streams#1031
fynngodau merged 1 commit intoTeamNewPipe:devfrom
petlyh:bandcamp-fix-radio-comments

Conversation

@petlyh
Copy link
Copy Markdown
Contributor

@petlyh petlyh commented Feb 23, 2023

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
    No NewPipe changes required.

Comments are now shown as disabled on Bandcamp radio streams, which do not have comments.

Fixes TeamNewPipe/NewPipe#9732

Before After
image image

@AudricV AudricV added bug Issue or PR is related to a bug Bandcamp Service, https://bandcamp.com labels Feb 23, 2023
@AudricV AudricV requested a review from fynngodau February 23, 2023 20:03
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but I have no knowledge of Bandcamp

Copy link
Copy Markdown
Member

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing change, thanks a lot for opening the PR!

@fynngodau fynngodau merged commit 3fdb6ee into TeamNewPipe:dev Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bandcamp Service, https://bandcamp.com bug Issue or PR is related to a bug

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Bandcamp -> Radio shows a "Sorry, something went wrong" error

4 participants