Use Comparator factory methods.#8728
Merged
Stypox merged 3 commits intoTeamNewPipe:devfrom Aug 6, 2022
Merged
Conversation
Stypox
requested changes
Aug 4, 2022
| * @throws IllegalArgumentException if the term or query is {@code null} | ||
| */ | ||
| public Integer fuzzyScore(final CharSequence term, final CharSequence query) { | ||
| public int fuzzyScore(final CharSequence term, final CharSequence query) { |
Member
There was a problem hiding this comment.
I think this was taken from here. Does the apache license allow modifying code? If so, does it require changes to be documented?
Member
Author
There was a problem hiding this comment.
I undid the change, just in case.
99dc474 to
d1f3f15
Compare
Stypox
requested changes
Aug 6, 2022
Stypox
approved these changes
Aug 6, 2022
Member
Stypox
left a comment
There was a problem hiding this comment.
I tested the download dialog, also ListHelper tests pass, so this is fine
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Comparatorfactory methods.Comparator.comparingDouble()in the preference search to avoid boxing.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence