Reduce View.kt size.#8708
Merged
Stypox merged 2 commits intoTeamNewPipe:devfrom Aug 6, 2022
Merged
Conversation
40ec913 to
6cdb011
Compare
Stypox
requested changes
Aug 3, 2022
Comment on lines
+277
to
+281
| private class RunnableExecutorAdapter( | ||
| private val view: View, | ||
| private val execOnEnd: Runnable?, | ||
| private val shouldHideView: Boolean | ||
| ) : AnimatorListenerAdapter() { | ||
| override fun onAnimationEnd(animation: Animator) { | ||
| if (shouldHideView) { | ||
| view.isGone = true | ||
| } | ||
| execOnEnd?.run() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I'd create two classes, one for when shouldHideView is true, one for when it's false, in order to avoid that runtime check (maybe the second can extend the first, but idk). The names for the two classes should be imo: HideAndExecOnEndListener and ExecOnEndListener. RunnableExecutorAdapter is not so meaningful.
be334cd to
d65683f
Compare
d65683f to
8024b43
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Aug 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
View.kt.AnimatorListenerAdapter.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence