Actually fix history view count

[Stypox]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

#8336 did not really fix the problem, it just made so that each item in history has 1 less view. This meant that, even though the bug appeared to be fixed the first time a video is opened (since that video's views are correctly set to 1), the second time the same video is opened the views are incorrectly set to 3. And #8336 actually introduced a regression, since e.g. enqueued videos were registered as "No views" as reported in #8336 (comment).

The underlying problem was an incorrect usage of Java's == (same) operator: it was used in the player's onEvents function to check if the media item tag in the ExoPlayer was equal to the one currently set in our Player. The problem with this is, when the player is started from scratch, the media item tag is first updated with a tag with no LoadedMediaSource attached (since the player is still loading the media source), and then updated again when the media source was loaded. The second update created a new instance of the media item tag (see StreamInfoTag.withExtras() and its usage in LoadedMediaSource and FailedMediaSource), so the == operator is not suitable for comparing them. When the player is not started from scratch, but rather just switches to the next item in the queue, only 1 view was (correctly) registered, since the media source is usually already loaded because of the mechanism of pre-fetching the next item in the queue.

This PR solves the issue by comparing the stream info url associated with the media item tag before calling updateMetadataWith() with the new stream info.

This PR also makes it so that marking a video as watched does not add one view to it, and also does not update its last access time. Now a new history entry with 0 views is added, and this happens only if one did not exist before. Tell me if I should revert this.

Fixes the following issue(s)

• Replaces Fix history view count #8336
• Really fixes NewPipe client counts 1 view as 2 views #8330

APK testing

app-debug.zip

Due diligence

• I read the contribution guidelines.

[litetex]

LGTM

[AudricV]

I didn't really reviewed the whole code but found an optimization in it that you may use.

I trust @litetex for the rest of the code :)

[AudricV]

You can use getCurrentStreamInfo() method to do so, unless you want to avoid confusion between the previous info and the current one :)

Suggested change

	final StreamInfo previousInfo = Optional.ofNullable(currentMetadata)
	.flatMap(MediaItemTag::getMaybeStreamInfo).orElse(null);
	final StreamInfo previousInfo = getCurrentStreamInfo().orElse(null);

Reminder of getCurrentStreamInfo() method

    private Optional<StreamInfo> getCurrentStreamInfo() {
        return Optional.ofNullable(currentMetadata).flatMap(MediaItemTag::getMaybeStreamInfo);
    }

[Stypox]

Even tough to my eye your suggestion looks better, I'd prefer to keep the current code as it shows where the stream info comes from