Crop the notification thumbnail in 1:1 mode instead of stretching it#8533
Merged
Stypox merged 6 commits intoTeamNewPipe:devfrom Jul 13, 2022
OxygenCobalt:crop-notification-large-icon
Merged
Crop the notification thumbnail in 1:1 mode instead of stretching it#8533Stypox merged 6 commits intoTeamNewPipe:devfrom OxygenCobalt:crop-notification-large-icon
Stypox merged 6 commits intoTeamNewPipe:devfrom
OxygenCobalt:crop-notification-large-icon
Conversation
Change the bitmap transformation strategy when a 1:1 aspect ratio is enabled to not stretch the bitmap but rather crop it. On Android 11/12, the way the whole thumbnail was used for the notification icon was not ideal, however the setting to toggle a 1:1 (as it states in settings) resulted in distortions. Fix this by simply cropping the bitmap.
Contributor
Author
|
By the way @opusforlife2, should I update the setting string to remove the "May cause distortions" portion? Or will this be done by the maintainers? |
Collaborator
|
Go ahead. 👍 |
Update the 1:1 mode strings to remove mentions of scaling or distortions, as those no longer apply.
Contributor
Author
|
Done. This can probably be merged now @opusforlife2. |
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
Note: we have to delete translations of the strings updated in this PR in order to apply their changes in translations. |
Member
|
Uhm, no? Weblate already takes care of asking translators to re-translate outdated strings, if I remember correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
While using the whole thumbnail for the notification's large icon works fine on Android 10 and below, it breaks down on Android 11/12, in which it leaves a large amount of whitespace. The 1:1 option is also not ideal here, as it distorts the thumbnail in an unappealing manner.
This PR changes the scaling mechanism used to crop the thumbnail to a 1:1 ratio instead of stretching it. More specifically, it picks the smaller dimension from the thumbnail and then scales the larger dimension down to fit, cropping the thumbnail to the center in the process. I feel this is much better than how the option currently works.
Before/After Screenshots/Screen Record
Before:
After:
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence