Made some much needed changes to the ReadMe#8372
Merged
Conversation
Poolitzer
previously requested changes
May 8, 2022
Member
Poolitzer
left a comment
There was a problem hiding this comment.
nanananananananana nitpicking
| * 1080p/2K/4K support | ||
| * Search videos, audios, channels, playlists and albums | ||
| * Browse videos and audios within a channel | ||
| * Subscribe to channels (yes, without logging into any account!) |
Collaborator
Author
There was a problem hiding this comment.
Again, what joke?
Contributor
There was a problem hiding this comment.
@Poolitzer probably meant the phrase in parentheses. I'd say to keep it, as it points out to the reader that login is not needed to subscribe to channels.
Contributor
|
Wait on me a few days and then I'll get to take a look at this. |
triallax
suggested changes
May 13, 2022
Contributor
triallax
left a comment
There was a problem hiding this comment.
Here's my review, sorry for the delay.
| * 1080p/2K/4K support | ||
| * Search videos, audios, channels, playlists and albums | ||
| * Browse videos and audios within a channel | ||
| * Subscribe to channels (yes, without logging into any account!) |
Collaborator
Author
|
@mhmdanas I think you added comments to Pool's review within your review? That seems like the reason most of your comments are duplicated. I normally comment on other reviews separately. |
Contributor
|
@opusforlife2 that's right, I realized that after I submitted the review. |
Co-authored-by: Mohammed Anas <triallax@tutanota.com> Co-authored-by: Poolitzer <github@poolitzer.eu>
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
triallax
approved these changes
Jun 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Due diligence