Add PlPredicate, PlModule classes#32
Conversation
- also removed some unused parameter defaults
| { | ||
| public: | ||
| explicit PlPredicate() | ||
| : WrappedC<predicate_t>(PlPredicate::null) { } |
There was a problem hiding this comment.
I don't think there is any scenario I'm aware of where it is useful to have a NULL predicate pointer.
There was a problem hiding this comment.
Removed (it was in rocksdb, but I've now made it explicit)
|
|
||
| class PlModule : public WrappedC<module_t> | ||
| { | ||
| public: |
There was a problem hiding this comment.
Here we may have a null constructor. Practically all API functions accept a NULL module as a shorthand for the current calling context, defaulting to user if such a context does not exist (when we make calls to Prolog without being called by Prolog).
There was a problem hiding this comment.
I've added a constructor that takes module_t, so PlModule(PlModule::null) is now possible.
|
Great. I've lost track a little with all the PRs. When done, can you tell me by mail which to merge? |
- also removed some unused parameter defaults
|
Thanks. Squashed with #31. Added an additional patch to reduce the time needed for the overflow test by temporary lowering the stack limit. |
This is a follow-on to PR #31