Depends on constant that is only in nokogiri 1.5+#78
Merged
stouset merged 1 commit intoSAML-Toolkits:masterfrom Apr 5, 2013
Merged
Depends on constant that is only in nokogiri 1.5+#78stouset merged 1 commit intoSAML-Toolkits:masterfrom
stouset merged 1 commit intoSAML-Toolkits:masterfrom
Conversation
stouset
added a commit
that referenced
this pull request
Apr 5, 2013
Depends on constant that is only in nokogiri 1.5+
|
Those constants are actually defined in 1.5.1. They do not exist in Nokogiri 1.5.0. |
Contributor
|
Just ran into this issue. @ericenphase is correct that 1.5.1 is the required Nokogiri |
Contributor
Author
|
One of you guys should make a pull request requiring 1.5.1 or above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when including into an app that already was locked at a nokogiri 1.4.x version. It gave the following error:
uninitialized constant Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0
That constant came into being with nokogiri 1.5, so this should depend on that.