v2.0: Support DSA and ECDSA signing keys#705
Merged
pitbulk merged 6 commits intoSAML-Toolkits:v2.xfrom Sep 30, 2024
Merged
Conversation
14 tasks
e92177f to
f771caa
Compare
Collaborator
Author
|
@pitbulk this is ready for your initial review. I'll give it another pass tomorrow but the core changes and tests are basically working 🎉 |
…y PEM values, including the `RubySaml::Util#format_cert` and `#format_private_key` methods. Introduces new `RubySaml::PemFormatter` module.
4680d8d to
9430fe9
Compare
Collaborator
Author
9430fe9 to
f9cbf62
Compare
Collaborator
Author
|
@pitbulk FYI I am now running this branch in prod without issue. |
Collaborator
|
@johnnyshields, merged this one but rubocop needs to be fixed |
bcgraham
pushed a commit
to vericred/ruby-saml
that referenced
this pull request
Nov 5, 2025
* v2.0 Support EC/DSA crypto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #661
Replaces #683
Depends on #711, please merge it first.
Currently RubySaml supports only RSA keys. The SAML standard can also support ECDSA and DSA keys. This PR adds support for both:
JRuby supports DSA but cannot support ECDSA due to this issue.
You may not use EC/DSA keys for encryption. An
ArgumentErroris raised if you attempt to do so.It includes the following changes, which are all done in a backward compatible manner:
settings.security[:signature_method]now ignores the "rsa" component of its user-set value and automatically uses whatever type of SP signing public key you actually set (e.g. a DSA key) plus the "sha" component of the value.settings.security[:signature_method]supports shortcut values:sha1,:sha256, etc.:rsa_sha256,:dsa_sha256etc. also work, but as per above the "rsa"/"dsa" are ignored in favor of the SP public key type.settings.security[:digest_method]supports shortcut valuessha1,sha256, etc.XMLSecurity::Cryptois extracted fromXMLSecurity::DocumentDONE: