replace "strip!" from SAML signing digest#647
Closed
bramleyjl wants to merge 6 commits intoSAML-Toolkits:masterfrom
Closed
replace "strip!" from SAML signing digest#647bramleyjl wants to merge 6 commits intoSAML-Toolkits:masterfrom
bramleyjl wants to merge 6 commits intoSAML-Toolkits:masterfrom
Conversation
…e_strip! changes "strip!" to "strip" to enable successful SAML signing
…e_version_1_14_1 updates version to 1.14.1
SAML-Toolkits update
Collaborator
|
Fixed in #650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for a fix to the
compute_digestmethod that was rendering anildigest after Base64-encoding it. The reason for this bug is the usage of strip!, a method that returnsnilif no whitespace is found on either end of the string to be stripped. By replacing it with strip, an identical method that will return the original string if no whitespace is found to be stripped, this bug can be prevented.We on the VA.gov development team have been using a forked version of the Ruby-SAML gem with this change since October and have not had any issue with it.
External Links
Link to original issue: #643
Link to code at issue: https://github.com/SAML-Toolkits/ruby-saml/blob/master/lib/xml_security.rb#L178