Skip to content

Allow optional prefix for AuthNRequest ID attribute#630

Closed
gowda wants to merge 2 commits intoSAML-Toolkits:masterfrom
PranaDiabetes:authrequest-id
Closed

Allow optional prefix for AuthNRequest ID attribute#630
gowda wants to merge 2 commits intoSAML-Toolkits:masterfrom
PranaDiabetes:authrequest-id

Conversation

@gowda
Copy link
Copy Markdown

@gowda gowda commented Jan 14, 2022

ID attribute is returned as InResponseTo attribute of the response by servers (as mentioned by Azure documentation).

@pitbulk
Copy link
Copy Markdown
Collaborator

pitbulk commented Jan 20, 2022

It makes more sense to add the prefix to the uuid method ot the Utils, rather than in only the request constructor.

You can add a constant to the Utils class by default "_" (the current prefix) so then later the user will be able to override it dinamycally

@gowda gowda changed the title Allow optional prefix & suffix for AuthNRequest ID attribute Allow optional prefix for AuthNRequest ID attribute Jan 22, 2022
@gowda
Copy link
Copy Markdown
Author

gowda commented Jan 22, 2022

It makes more sense to add the prefix to the uuid method ot the Utils, rather than in only the request constructor.

You can add a constant to the Utils class by default "_" (the current prefix) so then later the user will be able to override it dinamycally

I have update Utils.uuid method to accept an optional prefix which is set to _ by default.

@pitbulk
Copy link
Copy Markdown
Collaborator

pitbulk commented Jan 24, 2022

I dislike the need of changing code in all the places where uuid is used with the new parameter.

Can you instead follow my suggestion and just add a param to the Util class, by default "_" and then change the uuid in order to use it.

developers that want the new behavior only will need to change the attribute from the Util class and that all.

pitbulk added a commit that referenced this pull request Jan 31, 2022
@pitbulk
Copy link
Copy Markdown
Collaborator

pitbulk commented Jan 31, 2022

prefix support gonna be included at #633

@pitbulk pitbulk closed this Jan 31, 2022
pitbulk added a commit that referenced this pull request Jan 31, 2022
Support ability to change ID prefix. See #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants