Added Regex support for fractional seconds duration#589
Closed
gpinkham wants to merge 1 commit intoSAML-Toolkits:masterfrom
Closed
Added Regex support for fractional seconds duration#589gpinkham wants to merge 1 commit intoSAML-Toolkits:masterfrom
gpinkham wants to merge 1 commit intoSAML-Toolkits:masterfrom
Conversation
Author
|
just realized someone else already has a PR for this fix.. only diff is the way we tested I'll leave this here just in case it's needed but feel free to close it if you want.. thanks! |
Collaborator
|
Think we should close this in favor of #586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
Had a customer send in XML that had a valid duration with fractional seconds (0.000S) but the Regex parser did not support that. . Updated Regex expression to support fractional seconds. Backwards compatible to support integer seconds (0S)
Related PRs
None
Todos
Deploy Notes
None
Steps to Test or Reproduce
Duration that failed with current code: "P0Y0M30DT0H0M0.000S"
Impacted Areas in Application