Fix: issues affecting the code quality#567
Merged
pitbulk merged 8 commits intoSAML-Toolkits:masterfrom Jan 2, 2023
Merged
Conversation
pitbulk
reviewed
Feb 22, 2021
| # @return [Boolean] True if the SessionNotOnOrAfter of the AuthnStatement is valid, otherwise (when expired) False if soft=True | ||
| # @raise [ValidationError] if soft == false and validation fails | ||
| # | ||
| def validate_session_expiration(soft = true) |
Collaborator
There was a problem hiding this comment.
I believe we can simply remove the param
Contributor
Author
|
Hi @pitbulk 👋 Please review the PR ✨ |
Collaborator
|
👍 looks good to merge |
withshubh
commented
Nov 9, 2021
Collaborator
|
@pitbulk let's merge this one? |
pitbulk
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues that were affecting the code quality.
Summary of changes
StandardErroroverException