Audience validation with only a closing tag#444
Merged
pitbulk merged 3 commits intoSAML-Toolkits:masterfrom Feb 28, 2018
Merged
Audience validation with only a closing tag#444pitbulk merged 3 commits intoSAML-Toolkits:masterfrom
pitbulk merged 3 commits intoSAML-Toolkits:masterfrom
Conversation
It was discovered that self closing tags return "" now instead of nil. Discussed the possible fixes on: SAML-Toolkits#443
After discussion on: SAML-Toolkits#443 We determined that it was related to the way that the text is being returned and checked. In my previous commit I applied the change discussed in the issue above. This commit adds a new response and test that fails before the and passes once the change is added. I used a SAML tool to produce a new response that has the unexpected selfclosing tag and included it in the test/responses folder.
In this commit I'm putting the tests back the way they were and restoring the logic in the Utils.element_text. Instead I'm applying the change that @brianswko suggested at the start of SAML-Toolkits#443 This still allows for my new test to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
There was a problem where the validation would fail if the IDP sent back an audience block with a self closing tag. I've included a new response that does just that and applied the fix discussed in: #443