Cleanup SamlMessage class#214
Merged
Lordnibbler merged 5 commits intoSAML-Toolkits:masterfrom Mar 26, 2015
Merged
Conversation
* this was in the process of being refactored when SAML-Toolkits#211 was merged
Contributor
There was a problem hiding this comment.
i'd opt for the opposite here, based on hound/rubocop -- double quote " only when using string interpolation, and single quote ' everywhere else
Contributor
|
nice aside from my comment -- can you adjust the quotes? sorry to nitpick |
* remove duplication by using local `deflate` method * remove unnecessary variable assignment
266441b to
db7505b
Compare
Contributor
Author
|
@Lordnibbler no worries, I have updated the quotes. |
Contributor
|
👍 |
Lordnibbler
added a commit
that referenced
this pull request
Mar 26, 2015
Cleanup `SamlMessage` class
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes some cleanups from working on other PRs. The commit messages should be self-explanatory.