Fix the PR #99

[pitbulk]

Add AuthnContextDeclRef and AuthContext comparison support.
Remove AuthContext from LogoutRequest

[pitbulk]

@luisvm , @Lordnibbler can you review it?

[Lordnibbler]

@pitbulk the build on TravisCI is failing for Ruby 1.8.7, can you look into why?

[pitbulk]

Is strange, First time I execute bundle exec rake

/home/pitbulk/.rvm/rubies/ruby-1.8.7-head/bin/ruby -I"lib:lib:test" -I"/home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib" "/home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
  * DEFERRED: XmlSecurity::SignedDocument #extract_inclusive_namespaces should support inclusive canonicalization. 
Loaded suite /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib/rake/rake_test_loader
Started
...........FF.......................................................................................
Finished in 0.980707 seconds.
  1) Failure:
test: Authrequest should create the saml:AuthnContextClassRef with comparison exact. (RequestTest)
    [/home/pitbulk/proyectos/ruby-saml/test/request_test.rb:159:in `__bind_1414427782_383156'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/shoulda-2.11.3/lib/shoulda/context.rb:382:in `call'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/shoulda-2.11.3/lib/shoulda/context.rb:382:in `test: Authrequest should create the saml:AuthnContextClassRef with comparison exact. '
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/mocha-0.14.0/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:29:in `__send__'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/mocha-0.14.0/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:29:in `run']:
<nil> is not true.

  2) Failure:
test: Authrequest should create the saml:AuthnContextClassRef with comparison minimun. (RequestTest)
    [/home/pitbulk/proyectos/ruby-saml/test/request_test.rb:169:in `__bind_1414427782_384138'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/shoulda-2.11.3/lib/shoulda/context.rb:382:in `call'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/shoulda-2.11.3/lib/shoulda/context.rb:382:in `test: Authrequest should create the saml:AuthnContextClassRef with comparison minimun. '
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/mocha-0.14.0/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:29:in `__send__'
     /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/mocha-0.14.0/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:29:in `run']:
<nil> is not true.

Same output than Travis, but If I execute the test again:

bundle exec rake
/home/pitbulk/.rvm/rubies/ruby-1.8.7-head/bin/ruby -I"lib:lib:test" -I"/home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib" "/home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
  * DEFERRED: XmlSecurity::SignedDocument #extract_inclusive_namespaces should support inclusive canonicalization. 
Loaded suite /home/pitbulk/.rvm/gems/ruby-1.8.7-head/gems/rake-10.3.2/lib/rake/rake_test_loader
Started
....................................................................................................
Finished in 0.961662 seconds.
100 tests, 167 assertions, 0 failures, 0 errors

[pitbulk]

Is a problem with the regular expression

[pitbulk]

@luisvm , @Lordnibbler can you review it?

[Lordnibbler]

I would recommend wrapping code snippets in ticks like settings.authn_context_decl_ref (see raw source)

[Lordnibbler]

👍 looks good other than my readme comments