explicitly require "onelogin/ruby-saml/logging"

[nkeyes]

so that the developer may do:

require 'onelogin/ruby-saml/authrequest'

instead of

require 'onelogin/ruby-saml'

or

require 'onelogin/ruby-saml/authrequest'
require 'onelogin/ruby-saml/logging'

[Lordnibbler]

Can you add documentation for this feature, @nkeyes ?

[nkeyes]

I'm not sure what documentation is needed or where it would go, so I'll explain what I did here.
All I did was add the proper require statements so that one can directly require 'onelogin/ruby-saml/authrequest' without an error.

The project I was working on only needed OneLogin::RubySaml::Authrequest, but to get that I'd either have to require 'onelogin/ruby-saml', unnecessarily loading loading the whole library, or require authrequest, and logging. OneLogin::RubySaml::Authrequest depends on OneLogin::RubySaml::Logging, so it should be required from that file.

[Lordnibbler]

@nkeyes Can you just add the information from your pull request description into the readme.md?

[nkeyes]

Yeah, I can do that later tonight.

[Lordnibbler]

Great we will merge after that!

[Lordnibbler]

@nkeyes just following up --

@luisvm @pitbulk @inakidelamadrid can you guys review? this is 👍 from me after documentation is added

[pitbulk]

After merge this pull-request I think a message could be added to the Readme.md (since there is no reference to any requires in the README.md),

I think one place to set it is at the Overview section, before the "The initiation phase". Something like:

In order to use the toolkit you will need to add the library in your ruby project.

you can add the whole toolkit:

require 'onelogin/ruby-saml'

or just the required part:

require 'onelogin/ruby-saml/authrequest'

What do you think?

@Lordnibbler , can you merge it and commit this proposed doc or any?

[Lordnibbler]

@pitbulk sure will do that now.

[Lordnibbler]

@pitbulk done via b7ee3d7