Packing SAML Response attribute values in an array when there is more than one xml node with the same key#112
Closed
miguelpais wants to merge 2 commits intoSAML-Toolkits:masterfrom
Conversation
… than one xml node with the same key (critical for fetching all the assigned roles to a user from the response)
Contributor
|
@miguelpais can you add specs for this? |
Author
|
Done |
Author
|
If you're wondering why I ended up doing this in the first place, it's because I happen to have some webapp using calh's fork of "ruby-saml" and integrating with Redhat's Picketlink solution, which happens to send user roles in this way on the SAML-response. You can decide if this small functionality is useful or not. P.S.: I happen to be using calh's fork and not the official ruby-saml, because, if I remember correctly, you guys didn't support the single logout scenario (by not allowing an sp from sending a logout-response). |
Contributor
|
I created a pull request #122 that fixes this issue in a backwards compatible manner |
kwugirl
referenced
this pull request
in newrelic/ruby-saml
Jun 27, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packing SAML Response attribute values in an array when there is more than one xml node with the same key.
This is useful, for instance, for fetching multiple roles assigned to a user, which currently is not supported (the last role defined will be the one retrieved because the key to value assignment on the attributes map keeps replacing the value).