The check_idp_cert_expiration should improved as follows:
- If true and there are multiple IdP certs, we should skip expired IdP certs and use the first one which is not expired. We should only raise the "IdP cert expired" error if there are no non-expired certs.
- If true, we should check the e
not_before condition (not yet ready). Currently we only check the not_after condition (expired).
The corresponding changes for SP certs are done here: #673
FYI: I have this sort of logic already coded in my app, I will review what can be ported to RubySaml gem.
The
check_idp_cert_expirationshould improved as follows:not_beforecondition (not yet ready). Currently we only check thenot_aftercondition (expired).The corresponding changes for SP certs are done here: #673
FYI: I have this sort of logic already coded in my app, I will review what can be ported to RubySaml gem.