remove references to python 2.7#398
Merged
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom Jun 17, 2024
Merged
Conversation
abaf7e2 to
5e25402
Compare
Contributor
Author
|
@pitbulk can I have workflow approval 🥹 ? |
| 'Programming Language :: Python :: 3.11', | ||
| 'Programming Language :: Python :: 3.12', | ||
| ], | ||
| python_requires='>=3.5', |
Contributor
There was a problem hiding this comment.
is there any reason why Python versions that are no longer receiving (security) updates should still be supported?
Python 3.8 will be EOL in October 2024, so I would aim to support only Python 3.8+.
Contributor
Author
There was a problem hiding this comment.
I am just doing a slight cleanup, aligning the metadata with what the project claims. I could totally remove deprecated python version support in a different dedicated PR.
@sergei-maertens do you have the merge permission?
Contributor
There was a problem hiding this comment.
I do not, I'm mostly tracking upstream changes to maintain our own fork
5e25402 to
489c620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.