This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Reflected Aqua's converter refactoring#933
Merged
nonhermitian merged 13 commits intoQiskit:masterfrom Aug 13, 2020
Merged
Conversation
Cryoris
reviewed
Jul 30, 2020
| "metadata": {}, | ||
| "source": [ | ||
| "Call encode method of `LinearEqualityToPenalty` to convert." | ||
| "Call `conevrt` method of `LinearEqualityToPenalty` to convert." |
Contributor
There was a problem hiding this comment.
Suggested change
| "Call `conevrt` method of `LinearEqualityToPenalty` to convert." | |
| "Call `convert` method of `LinearEqualityToPenalty` to convert." |
Contributor
|
The PR that this was depending on in Aqua has been merged, could you merge the current master branch and trigger the tests @nonhermitian or @a-matsuo? |
Contributor
|
This works on released qiskit versions. So will need to wait for release to verify. |
Contributor
|
Ah alright, thanks! 👍 |
Contributor
Author
|
@nonhermitian @Cryoris I ran notebooks on the latest version, and no errors occurred. Could you please check this PR? |
This was referenced Aug 12, 2020
Contributor
|
There are some styling issues that need to be resolved
|
Contributor
Author
|
Hi @nonhermitian, I fixed the styling issues. Could you please check it again? |
nonhermitian
approved these changes
Aug 13, 2020
Contributor
nonhermitian
left a comment
There was a problem hiding this comment.
Looks good, thanks!
manoelmarques
pushed a commit
to manoelmarques/qiskit-optimization
that referenced
this pull request
Mar 5, 2021
* reflect converter refactoring(Qiskit/qiskit-tutorials#1061) * fixed the sentences of the 2nd and 3rd tutorials * fixed typo * Add pyscf to azure build * run them on the latest version of Qiskit * updated kernel specs * fixed styling issues Co-authored-by: Paul Nation <nonhermitian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reflected Aqua's converter refactoring
Details and comments
Some methods names in tutorials were changed according to qiskit-community/qiskit-aqua#1061