Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41)#404

Merged
quantumjim merged 4 commits intoQiskit:masterfrom
holly-cummins:master
Dec 7, 2018
Merged

Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41)#404
quantumjim merged 4 commits intoQiskit:masterfrom
holly-cummins:master

Conversation

@holly-cummins
Copy link
Copy Markdown
Contributor

@holly-cummins holly-cummins commented Dec 4, 2018

  • Fix some deprecation warnings related to using global functions rather than the new IBMQ ones
  • Use 7-bit ASCII and a 14-bit register, in order to enable ...
  • ... using ibmq_melbourne_16 as the backend rather than the retired ibmqx5

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 4, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@quantumjim quantumjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks great.

One last remnant I noticed of the 8 bit version was in the following comments
# get string of the leftmost 8 bits and convert to an ASCII character
# do the same for string of rightmost 8 bits, and add it to the previous character
Could you change these 8s to 7s?

@holly-cummins
Copy link
Copy Markdown
Contributor Author

Good spot! Those are now fixed, thanks.

Copy link
Copy Markdown
Member

@quantumjim quantumjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@quantumjim quantumjim merged commit 12c379f into Qiskit:master Dec 7, 2018
quantumjim pushed a commit that referenced this pull request Dec 10, 2018
* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* update notebooks with the newest Terra and Aqua
jaygambetta added a commit that referenced this pull request Dec 15, 2018
* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* adding @pistoia as coowner of the community Aqua tutorials (#415)

* Update circuit drawing notebook for order changes again (#418)

At the last minute we decided to change the order back to what it was
before, and standardize on that for visualization. This commit adjusts
the visualizations in the notebook to that, by using
Qiskit/qiskit#1475 applied.

* Adding 07

* Small updates

* Adding update
jaygambetta added a commit that referenced this pull request Dec 15, 2018
* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* adding @pistoia as coowner of the community Aqua tutorials (#415)

* Update circuit drawing notebook for order changes again (#418)

At the last minute we decided to change the order back to what it was
before, and standardize on that for visualization. This commit adjusts
the visualizations in the notebook to that, by using
Qiskit/qiskit#1475 applied.

* Adding 07

* Small updates

* Adding update

* Basic versions working with 0.7
jaygambetta pushed a commit that referenced this pull request Dec 19, 2018
* Change introductory material in relaxation and decoherence NB

Tries to be a bit more clear about why these are issues we have
to characterize.

* Add more content on measurement of T1 time

Puts in a phenomenological description of the time
evolution of the density matrix, and also includes
the discrete-time channel that generates amplitude
damping noise.

Clarifies the experimental procedure for estimating the
T1 time.

* Add more content on measurement of T2^* time

This piece still needs to be fleshed out a bit
more to explain where the oscillating term comes
from. Also, it needs to explicitly point out
that amplitude damping contributes to T2^*,
which (I think) motivates the use of the Hanh echo
to isolate dephasing-like contributions to T2^*.

* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* Update 2 Ignis NBs to change "backend" to "provider"

Addresses a change introduced in Terra-0.7 where
"backends" has been renamed "providers".

* Remove personal note from Ignis NB on relaxation and decoherence
diego-plan9 pushed a commit that referenced this pull request Dec 19, 2018
* Terra07 (#406)

* Adding 07

* Small updates

* Adding update

* Update the notebooks to work with the newest Terra and Auqa  (#410)

* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* update notebooks with the newest Terra and Aqua

* update the grover+evolution+eoh+vqe2iqpe+h2qpe notebooks (#409)

* update grover notebook

* remove grover.py -- already covered in notebook

* update evolution notebook

* update vqe2iqpe notebook

* update eoh notebook

* update h2 qpe notebook

* remove redundant import

* update backend handling for declarative approaches

* add backend shots declaratively in qpe and grover notebooks

* adjust import statements (order, algorithms)

* Terra07 (#423)

* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* adding @pistoia as coowner of the community Aqua tutorials (#415)

* Update circuit drawing notebook for order changes again (#418)

At the last minute we decided to change the order back to what it was
before, and standardize on that for visualization. This commit adjusts
the visualizations in the notebook to that, by using
Qiskit/qiskit#1475 applied.

* Adding 07

* Small updates

* Adding update

* Terra07 (#425)

* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* adding @pistoia as coowner of the community Aqua tutorials (#415)

* Update circuit drawing notebook for order changes again (#418)

At the last minute we decided to change the order back to what it was
before, and standardize on that for visualization. This commit adjusts
the visualizations in the notebook to that, by using
Qiskit/qiskit#1475 applied.

* Adding 07

* Small updates

* Adding update

* Basic versions working with 0.7

* update notebooks to work with the newest Aqua (#411)

* update notebook to work with the newest Aqua

* update notebooks for optimization and ai

* update the import and update the tutorial to create pluggable algorithm/components.

* bug fix

* Fix EvolutionFidelity algorithm extension

* clean up the import and update the tutorial to register an algorithm

* rename the file name

* Terra07 (#429)

* Terra section

* Operations

* Terra07 (#430)

* Terra section

* Operations

* Adding circuits to terra0.7

* Circuits updated

* Updating qis_intro notebooks for qiskit 0.7 (#432)

* Updated algorithm tutorials for qiskit 0.7 (#433)

* terra_monitoring_notebook (#434)

* [WIP] Add notebook on rng (#417)

* Add notebook on rng

* Update with a run on the real device

* Aer tutorials (#416)

* add Qiskit Aer tutorials

* remove version note and contributors

* update index for Aer tutorials

* Fixing typos and other minor issues in the qiskit/basics-terra-aer tutorials (#437)

* fix import path names

* add monitoring notebook (#442)

* update ignis notebooks (#439)

* update imports for several `community/aqua` notebooks (#426)

* update imports

* update to use Aqua's get_aer_backend method

* Revert "update to use Aqua's get_aer_backend method"

This reverts commit e4179fa.

* Fix notebooks under qiskit/aqua (#443)

* update notebook to work with the newest Aqua

* update notebooks for optimization and ai

* update the import and update the tutorial to create pluggable algorithm/components.

* bug fix

* Fix EvolutionFidelity algorithm extension

* clean up the import and update the tutorial to register an algorithm

* rename the file name

* bug and typo fix

* remove redundant filter list

* Update finance and amplitude estimation notebooks (#435)

* add amplitude estimation notebook

* add euro-call-option and fixed-income notebooks

* update ae notebook to use aqua's get_aer_backend

* Revert "update ae notebook to use aqua's get_aer_backend"

This reverts commit 0d3bc08.

* update fixed-income notebook

* update aqua finance notebooks and amplitude estimation notebook

add contributors, add more descriptions, adjust code to terra  0.7

* Revert "update aqua finance notebooks and amplitude estimation notebook"

This reverts commit 7cfadfc.

* update aqua finance notebooks and amplitude estimation notebook

* update finance and amplitude estimation notebooks

use BasicAer to select backends and move amplitude estimation to qiskit/aqua/general/

* minor corrections in description of finance notebooks

* remove use of private function and switch to proper public ones

remove visualization._bloch and ._circuit_drawer

* Update amplitude_estimation.ipynb

correct comments and chart titles

* Remove personal notes from quantum operations tutorial. (#445)

* Small code fix to 2 Ignis NBs + content addition to another (#448)

* Change introductory material in relaxation and decoherence NB

Tries to be a bit more clear about why these are issues we have
to characterize.

* Add more content on measurement of T1 time

Puts in a phenomenological description of the time
evolution of the density matrix, and also includes
the discrete-time channel that generates amplitude
damping noise.

Clarifies the experimental procedure for estimating the
T1 time.

* Add more content on measurement of T2^* time

This piece still needs to be fleshed out a bit
more to explain where the oscillating term comes
from. Also, it needs to explicitly point out
that amplitude damping contributes to T2^*,
which (I think) motivates the use of the Hanh echo
to isolate dephasing-like contributions to T2^*.

* Switch quantum emoticon to use 7-bit ASCII and ibmq_melbourne_16 (fixes #41) (#404)

* Fix deprecation warnings

* Use 7-bit ascii encoding instead of 8, and use ibmq_melbourne_16 instead of ibmqx5

* Correct last remaining traces of 8-bittiness

* Update 2 Ignis NBs to change "backend" to "provider"

Addresses a change introduced in Terra-0.7 where
"backends" has been renamed "providers".

* Remove personal note from Ignis NB on relaxation and decoherence

* parallel notebook

* add matplotlib to env yml (#450)

* Documentation (#451)

* Update hello world folder to 0.7 (#453)

All update except laurel_or_yanny.ipynb

* Terra0 7 (#454)

* Update hello world folder to 0.7

All update except laurel_or_yanny.ipynb

* update hello quantum game engine to 0.7

* Update hello quantum engine to 0.7 (#455)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants