Fix a minification issue with the __hasRegisterFinished property.#5584
Fix a minification issue with the __hasRegisterFinished property.#5584kevinpschaaf merged 2 commits intomasterfrom
__hasRegisterFinished property.#5584Conversation
…er_renameProperty()`.
kevinpschaaf
left a comment
There was a problem hiding this comment.
While we're at it, I just searched the code and there are a few other hasOwnProperty checks with string literals that should be wrapped in JSCompiler_renameProperty:
- properties-changed.js:
__dataHasAccessor - properties-changed.js:
__dataAttributes - properties-mixin.js:
__observedAttributes
I spot checked these in compiled code and I don't see them being renamed (not entirely sure why), but for safety, let's go ahead and close the hole.
|
I've never actually used |
kevinpschaaf
left a comment
There was a problem hiding this comment.
Yeah that's right, 2nd arg is the context object for the property being dereferenced.
LGTM
Wrap
hasOwnPropertychecks for__hasRegisterFinishedinJSCompiler_renameProperty().