Ensure className bindings work correctly when ShadyDOM.noPatch is…#5518
Merged
Ensure className bindings work correctly when ShadyDOM.noPatch is…#5518
className bindings work correctly when ShadyDOM.noPatch is…#5518Conversation
… used. Puts `className` on `Polymer.dom` and ensures any sets to `className` in the binding system, go through that wrapper. Note, depends on webcomponents/shadydom#326.
kevinpschaaf
approved these changes
Apr 2, 2019
Member
kevinpschaaf
left a comment
There was a problem hiding this comment.
LGTM, maybe with a note that noPatch won't be compatible with innerHTML & textContent bindings won't be shady-compatible when in noPatch?
Member
|
Looks like some legit className failure in Chrome 41 and Safari 9 |
* Ensure `wrap` falls back to using `ShadyDOM.patch` when `noPatch` is not in use so that `className` can be used. * Ensure `Polymer.dom` uses `patch` when `noPatch` is not in use so that `className` can be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… used.
Puts
classNameonPolymer.domand ensures any sets toclassNamein the binding system, go through that wrapper.