Link to viking_room in ch. 8 is broken

[oddhack]

This throws up an error from Antora when building en/08_Loading_models.adoc . I believe the problem is the references to

* xref:attachment$viking_room.obj[viking_room.obj]

(and likewise viking_room.png) when the actual files are under attachments/assets (e.g. attachment$assets/ in Antora lingo, I think).

Also, not sure if this is supposed to work outside Antora, but I doubt it will because the markup is Antora-specific.

[SaschaWillems]

Fixed on main. Sadly there is no way to make Antora force attachments to be downloaded, so depending on your browser, the files will be directly opened in the browser instead.

[oddhack]

Fixed on main. Sadly there is no way to make Antora force attachments to be downloaded, so depending on your browser, the files will be directly opened in the browser instead.

It looks like in order to get a "download" attribute on the href generated from the xref, we would have to extend the converter per https://antora.zulipchat.com/#narrow/channel/282400-users/topic/.E2.9C.94.20Add.20target.20classes.20to.20xref.3F . Are you running into this a lot? If it's just a couple of links it doesn't seem worth the effort.

[SaschaWillems]

I don't think it's worth the effort. The tutorial only has very few links to assets, and people wanting to build and run the samples do so from their IDE anyway.

[oddhack]

I don't think it's worth the effort. The tutorial only has very few links to assets, and people wanting to build and run the samples do so from their IDE anyway.

Per Dan Allen, this may work:

xref:attachment$file.pdf[Attachment Title,role=auto-download]

[SaschaWillems]

Sadly doesn't seem to work. All this does (for me) is to add "auto-download" as an additional CSS class to the link.

[oddhack]

I think Dan misunderstood my question, but even when I try the 'download' href attribute in hand-edited HTML, it still does not download in Chromium. Some other browser setting must be overriding. I think the only way to do it would be to add a class with the 'role=' markup and then put in some JS which listens for clicks on links with that CSS class. Agreed, too much work.