Skip to content

Simplify unique extent check in RenderTarget<bindingType>::init functions#1524

Open
asuessenbach wants to merge 1 commit intoKhronosGroup:mainfrom
asuessenbach:render_target
Open

Simplify unique extent check in RenderTarget<bindingType>::init functions#1524
asuessenbach wants to merge 1 commit intoKhronosGroup:mainfrom
asuessenbach:render_target

Conversation

@asuessenbach
Copy link
Copy Markdown
Contributor

@asuessenbach asuessenbach commented Apr 22, 2026

Description

With #1517, we reduced the extent check in the RenderTarget<bindingType>::init functions from sorting the extents to counting the unique extents. But we actually just want to check if all extents are identical. And that can be easily done with this call to std::ranges::find_if. And this works regardless of whether VULKAN_HPP_HAS_SPACESHIP_OPERATOR is defined or not.

The previous approach nicely showed, how vulkan_hash.hpp can be used to use vulkan structs as the key in a std::unordered_set, but it's actually not needed.

Build tested on Win11 with VS2022. Run tested on Win11 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach asuessenbach requested a review from a team April 22, 2026 10:05
pull Bot pushed a commit to lomanclark818-stack/Vulkan-Samples that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants