Simplify unique extent check in RenderTarget<bindingType>::init functions#1524
Open
asuessenbach wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Simplify unique extent check in RenderTarget<bindingType>::init functions#1524asuessenbach wants to merge 1 commit intoKhronosGroup:mainfrom
asuessenbach wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
tomek-brcm
approved these changes
Apr 23, 2026
SaschaWillems
approved these changes
Apr 27, 2026
pull Bot
pushed a commit
to lomanclark818-stack/Vulkan-Samples
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With #1517, we reduced the extent check in the
RenderTarget<bindingType>::initfunctions from sorting the extents to counting the unique extents. But we actually just want to check if all extents are identical. And that can be easily done with this call tostd::ranges::find_if. And this works regardless of whetherVULKAN_HPP_HAS_SPACESHIP_OPERATORis defined or not.The previous approach nicely showed, how
vulkan_hash.hppcan be used to use vulkan structs as the key in astd::unordered_set, but it's actually not needed.Build tested on Win11 with VS2022. Run tested on Win11 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: