#modify net.sf.jsqlparser.statement.insert.Insert Method:toString()…#325
Merged
wumpz merged 1 commit intoJSQLParser:masterfrom Aug 18, 2016
Merged
#modify net.sf.jsqlparser.statement.insert.Insert Method:toString()…#325wumpz merged 1 commit intoJSQLParser:masterfrom
wumpz merged 1 commit intoJSQLParser:masterfrom
Conversation
…f itemsList and useSelectBrackets together not null will error #modify PlainSelect.getStringList change sql append to StringBuilder
|
|
||
| for (int i = 0; i < list.size(); i++) { | ||
| ans += "" + list.get(i) + ((i < list.size() - 1) ? comma + " " : ""); | ||
| ans.append(list.get(i)).append(((i < list.size() - 1) ? comma + " " : "")); |
Member
There was a problem hiding this comment.
To construct valid comma lists the constructs are nearly always weird :). You could use a commalist generator method within Plainselect. Nevertheless it was not your statement but the older one I am refering to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… if itemsList and useSelectBrackets together not null will error
modify PlainSelect.getStringList change sql append to StringBuilder