Support for COMMENT ON TABLE, COMMENT ON COLUMN...

Please add support for the following constructs ( used by Postgres, Oracle, Redshift ) :

COMMENT ON TABLE texto_fichero is "This is a sample comment";
COMMENT ON COLUMN texto_fichero.fichero_id is 'This is a comment';

MySql uses:
ALTER TABLE texto_fichero COMMENT "This is a sample comment";
ALTER TABLE texto_fichero MODIFY id COMMENT 'some comment';

[wumpz]

So first of all JSqlParser does not allow this double quoted string literals. For JSqlParser those are always object names.

So using single quotes these statements are parsed successfully using JSqlParser 3.2-SNAPSHOT:

COMMENT ON TABLE texto_fichero is 'This is a sample comment';
COMMENT ON COLUMN texto_fichero.fichero_id is 'This is a comment';

These alter statements are not yet supported.

[wumpz]

The normal comment statement was introduced late 2018 for issue #685.

Right, thank you, I found it. One small issue on Comment: it has two methods comment.getTable() and comment.getColumn() When using 'COMMENT ON COLUMN 'myTable.myColumn' is 'Some comment' it returns comment.getColumn().getColumnName() = "myTable.myColumn" and comment.getColumn().getTable() = null Wouldn't be correct that the column has also the Table set ( and not the table in the column name ) ? Please make sure the that it works also  COMMENT ON COLUMN 'mySchema.myTable.myColumn' is 'Some comment' Best regards, Dragos Pruteanu

…

-- DbSchema - Wise Coders GbmH 82256 Fürstenfeldbruck bei München Email: support@dbschema.com - Web: [1] http://dbschema.com/

-- [1] http://www.example.com/

[wumpz]

You are right. I will change this.

I will look into the alter statement to change the comments. Lets see how far I get with my somewhat limited time :).

[wumpz]

OK. I looked into it. The Comment class differs between commenting on a table or a column exactly by setting the table or the column. I tested your example and could not reproduce your error report. By the way, the column or table name may not be quoted. With those single quotes, it gives a parse exception. Here is my test:

    Comment comment = (Comment) CCJSqlParserUtil.parse("COMMENT ON COLUMN myTable.myColumn is 'Some comment'");
    assertThat(comment.getTable()).isNull();
    assertThat(comment.getColumn().getColumnName()).isEqualTo("myColumn");
    assertThat(comment.getColumn().getTable().getFullyQualifiedName()).isEqualTo("myTable");

It produces not this combined name myTable.myColumn like you described.

The second example including a schema name works as expected too:

    Comment comment = (Comment) CCJSqlParserUtil.parse("COMMENT ON COLUMN mySchema.myTable.myColumn is 'Some comment'");
    assertThat(comment.getTable()).isNull();
    assertThat(comment.getColumn().getColumnName()).isEqualTo("myColumn");
    assertThat(comment.getColumn().getTable().getFullyQualifiedName()).isEqualTo("mySchema.myTable");
    assertThat(comment.getColumn().getTable().getName()).isEqualTo("myTable");
    assertThat(comment.getColumn().getTable().getSchemaName()).isEqualTo("mySchema");

This was tested using JSqlParser 3.2-SNAPSHOT but should work in earlier versions as well.

So maybe you could review your bug report. I guess there is some other problem.

[wumpz]

So do you want go have this mysql variant of commenting using alter as well?

Yes, it would be nice to implement it. Best regards, Dragos Pruteanu

…

-- DbSchema - Wise Coders GbmH 82256 Fürstenfeldbruck bei München Email: support@dbschema.com - Web: [1] http://dbschema.com/

-- [1] http://www.example.com/

[wumpz]

So implementing those new constructs will take its time. So I will see, if I could get on it in the next days. OK?

Great, thank you ! Best regards, Dragos Pruteanu

…

-- DbSchema - Wise Coders GbmH 82256 Fürstenfeldbruck bei München Email: support@dbschema.com - Web: [1] http://dbschema.com/

-- [1] http://www.example.com/