Small improvements of tests#496
Merged
adam-sawicki-a merged 2 commits intoGPUOpen-LibrariesAndSDKs:masterfrom May 22, 2025
Merged
Small improvements of tests#496adam-sawicki-a merged 2 commits intoGPUOpen-LibrariesAndSDKs:masterfrom
adam-sawicki-a merged 2 commits intoGPUOpen-LibrariesAndSDKs:masterfrom
Conversation
Contributor
Author
|
Oh I just also realized the tests I wrote are not checking the return value of |
Contributor
|
Thank you for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vmaFlushAllocationis unnecessary here because vmaCopyMemoryToAllocation does that internally if it's required.This small mistake made it somehow through when discussing pull request #474.
I only found this in this test, the others seem to be correct.