Remove redundant if block#460
Closed
PawelGribov wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Closed
Remove redundant if block#460PawelGribov wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
PawelGribov wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Conversation
adam-sawicki-a
added a commit
that referenced
this pull request
Jan 29, 2025
Contributor
|
Does this change fix any bug, or just removes the code that we suspect to never execute? By the way, I fixed the triple "s" typo that you noticed. |
currentBlock and prevPhysical block can't be free at the same time at this moment.
2831674 to
4ad5e3b
Compare
Contributor
Author
|
It just removes the code that i suspect to never execute (but not really sure can it be hidden logic) |
Contributor
|
I am not sure either 🙂 and I don't have time right now to analyze it, as this is not a bug to be fixed, so I propose to leave it as-is. |
Contributor
Author
|
ok, closed 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave only else part. If I understand this TLSF logic correctly, two adjacent free blocks are merged immediately when one of them is freed. So the previous physical block will never be free.