Extended VmaAllocationInfo to include the size of the actual allocation#340
Closed
debaetsd wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Closed
Extended VmaAllocationInfo to include the size of the actual allocation#340debaetsd wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
debaetsd wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Conversation
…locateMemory) to VmaAllocationInfo
Contributor
|
Thank you for reporting this issue. I am sorry but I don't want to merge it. Query for Please feel free to maintain your fork of the code with this change. Another option could be using dedicated allocations or custom pools with specific I also suggest to rename the new parameter, as "allocation" is used in VMA to name a single sub-allocated region of a memory block, as in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended VmaAllocationInfo to include the actual allocation size (as-in the size used to allocate the memory when calling VkAllocateMemory).
We need the size when performing interop between Vulkan and OpenGL.
glImportMemoryFdEXTrequires the size of the actual underlying Vulkan object to be passed in (not the size of a suballocated resource).We worked around it by using dedicated allocations though extending VMA to query the size of the underlying allocation allows the benefits of the block allocator.