Fix ancient-remains foliage that uses alphaGen portal#1965
Open
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Open
Fix ancient-remains foliage that uses alphaGen portal#1965slipher wants to merge 2 commits intoDaemonEngine:masterfrom
slipher wants to merge 2 commits intoDaemonEngine:masterfrom
Conversation
For alphaGen portal, a "portal" shader was used, which was like the "generic" shader but with most features removed. Instead of that, move alphaGen portal support to the "generic" shader so that it can be combined with other features. This fixes the ancient-remains foliage which uses alphaGen portal to fade out when the camera is close, but also needs alpha testing which was not supported in the "portal" shader. (Also it's vertex-lit so it should use overbright.) I added back the capability for the "generic" shader to do vertex lighting, but the implementation is simpler than before.
Member
|
Oh that's very nice! I do remember having to disable the keywords in some WIP ports of the maps long time ago.<<<
At some point we may give it a more meaningful name, like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
alphaGen portalimplementation from theportalshader to thegenericone. This allows it to be combined with other features such as alpha testing. Fixes the grass texture on map ancient-remains that uses this alphagen trick to fade when the camera is close. Turns out portals are not the best use case of alphagen portal!2026-05-05.13-00-07.mp4
Also this change makes the black lines on the Pulse portal screens thinner, which matches Tremulous behavior. Maybe the
portalshader (now being NUKED because implementing the alphagen was its only purpose) also didn't have texture coordinates set up right.