Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the upstream-sync GitHub Actions workflow to enhance merge handling. Changes include granting Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
issues: writeso label and issue API calls succeedWhy
The current
maincopy ofupstream-sync.ymlis active, but it still has the same functional issues flagged in PR #18. Those issues can break label creation, misclassify a missing git identity as a merge conflict, and fail on reruns or conflict-report issue creation.Impact
This makes the scheduled upstream sync workflow safer to run on
Clarit-AI/Engramand preserves the intended behavior:Validation
git diff --check.github/workflows/upstream-sync.ymlClarit-AI/EngramNotes
The workflow itself does not start a Claude session. It fetches
sgl-project/sglang, attempts a merge into a generated branch, classifies risk, opens a PR or issue, and auto-merges only low-risk clean sync PRs.Summary by CodeRabbit