Conversation
|
|
sapphi-red
previously approved these changes
Sep 12, 2024
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
approved these changes
Sep 12, 2024
patak-cat
approved these changes
Sep 12, 2024
Member
patak-cat
left a comment
There was a problem hiding this comment.
Awesome! Great to see plain ifs enforced
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Co-authored-by: 翠 / green <green@sapphi.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable some rules in the eslint config marked TODO. Some are still disabled for playground code.
I left some as
'off'still as it felt like the better default for us.