Avoid some unnecessary buffering when reading config file

andrewmbenton · andrewmbenton · commit fa44949e7a5d · 2023-04-18T15:39:33.000-07:00
diff --git a/internal/cmd/generate.go b/internal/cmd/generate.go
@@ -100,13 +100,13 @@ func readConfig(stderr io.Writer, dir, filename string) (string, *config.Config,
 	}
 
 	base := filepath.Base(configPath)
-	blob, err := os.ReadFile(configPath)
+	file, err := os.Open(configPath)
 	if err != nil {
 		fmt.Fprintf(stderr, "error parsing %s: file does not exist\n", base)
 		return "", nil, err
 	}
 
-	conf, err := config.ParseConfig(bytes.NewReader(blob))
+	conf, err := config.ParseConfig(file)
 	if err != nil {
 		switch err {
 		case config.ErrMissingVersion:

Original file line number	Diff line number	Diff line change
`@@ -100,13 +100,13 @@ func readConfig(stderr io.Writer, dir, filename string) (string, *config.Config,`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`base := filepath.Base(configPath)`
`103`		`- blob, err := os.ReadFile(configPath)`
	`103`	`+ file, err := os.Open(configPath)`
`104`	`104`	`if err != nil {`
`105`	`105`	`fmt.Fprintf(stderr, "error parsing %s: file does not exist\n", base)`
`106`	`106`	`return "", nil, err`
`107`	`107`	`}`
`108`	`108`
`109`		`- conf, err := config.ParseConfig(bytes.NewReader(blob))`
	`109`	`+ conf, err := config.ParseConfig(file)`
`110`	`110`	`if err != nil {`
`111`	`111`	`switch err {`
`112`	`112`	`case config.ErrMissingVersion:`