final fixes

Author: kyleconroy

internal/compiler/analyze.go

@@ -56,6 +56,7 @@ func combineAnalysis(prev *analysis, a *analyzer.Analysis) *analysis {
 		})
 	}
 	if prev == nil {
+		// TODO: NO QUERY
 		return &analysis{
 			Columns:    cols,
 			Parameters: params,

internal/compiler/parse.go

@@ -55,6 +55,7 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 	var analysis *analysis
 	if c.analyzer != nil {
 		// We expect inference to fail sometimes
+		// TODO: Handle panics
 		inference, _ := c.inferQuery(raw, rawSQL)
 
 		query := rawSQL
@@ -73,7 +74,7 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 			return nil, err
 		}
 
-		// FOOTHGUN: Careful, combine mutates inference
+		// FOOTGUN: Careful, combine mutates inference
 		analysis = combineAnalysis(inference, result)
 	} else {
 		analysis, err = c.analyzeQuery(raw, rawSQL)

internal/endtoend/testdata/cte_select_one/postgresql/pgx/exec.json

@@ -1,5 +1,5 @@
 -- name: TestRecursive :one
 WITH t1 AS (
-    select 1
+    select 1 as foo
 )
 SELECT * FROM t1;

internal/endtoend/testdata/cte_select_one/postgresql/pgx/go/query.sql.go

@@ -1,6 +1,4 @@
 version: "2"
-cloud:
-  project: "01HAQMMECEYQYKFJN8MP16QC41"
 sql:
   - engine: "postgresql"
     schema: "schema.sql"
@@ -9,6 +7,4 @@ sql:
       go:
         package: "querytest"
         out: "go"
-        sql_package: "pgx/v5"
-    database:
-      managed: true
+        sql_package: "pgx/v5"

internal/endtoend/testdata/cte_select_one/postgresql/pgx/query.sql

@@ -231,6 +231,7 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
 
 	fmt.Println(query)
 
+	// TODO: Pick a random name
 	desc, err := c.Conn().Prepare(ctx, "foo", query)
 	if err != nil {
 		return nil, extractSqlErr(err)