Merge pull request #14 from tk0miya/remove_HTMLHelpBuilder.open_file

Remove HTMLHelpBuilder.open_file()

Author: tk0miya

CHANGES

@@ -1,6 +1,7 @@
-Release 1.0.3 (unreleased)
+Release 2.0.0 (unreleased)
 ==========================
 
+* Remove deprecated method: ``HTMLHelpBuilder.open_file()``
 * #6685: htmlhelp builder should generate HTML4 docs instead of HTML5
 
 Release 1.0.2 (2019-04-12)

sphinxcontrib/htmlhelp/__init__.py

@@ -10,9 +10,8 @@
 
 import html
 import os
-import warnings
 from os import path
-from typing import Any, Dict, IO, List, Set, Tuple, Type
+from typing import Any, Dict, List, Set, Tuple, Type
 
 from docutils import nodes
 from docutils.nodes import Element, Node, document
@@ -21,7 +20,6 @@
 from sphinx.application import Sphinx
 from sphinx.builders.html import StandaloneHTMLBuilder
 from sphinx.config import Config
-from sphinx.deprecation import RemovedInSphinx40Warning
 from sphinx.environment.adapters.indexentries import IndexEntries
 from sphinx.locale import get_translation
 from sphinx.util import logging
@@ -179,13 +177,6 @@ def prepare_writing(self, docnames: Set[str]) -> None:
         super().prepare_writing(docnames)
         self.globalcontext['html5_doctype'] = False
 
-    def open_file(self, outdir: str, basename: str, mode: str = 'w') -> IO:
-        # open a file with the correct encoding for the selected language
-        warnings.warn('HTMLHelpBuilder.open_file() is deprecated.',
-                      RemovedInSphinx40Warning)
-        return open(path.join(outdir, basename), mode, encoding=self.encoding,
-                    errors='xmlcharrefreplace')
-
     def update_page_context(self, pagename: str, templatename: str, ctx: Dict, event_arg: str) -> None:  # NOQA
         ctx['encoding'] = self.encoding