Skip to content

Commit 25220bf

Browse files
committed
dep(test): test against libxml-ruby v6 (#3618)
**What problem is this PR intended to solve?** CI has been failing since libxml-ruby v6 came out with a breaking change to the require path. Pin to `>= 6` and update the require statement. (cherry picked from commit 750d8eb)
1 parent 0caeb21 commit 25220bf

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Gemfile-libxml-ruby

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
ENV['TEST_NOKOGIRI_WITH_LIBXML_RUBY'] = "1"
2-
gem "libxml-ruby", :platform => :mri, :require => false
2+
gem "libxml-ruby", ">= 6", :platform => :mri, :require => false
33
eval_gemfile File.join(File.dirname(ENV['BUNDLE_GEMFILE']),"Gemfile")

test/helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
# which will a) bundle that gem, and b) set the appropriate env var to
3232
# trigger this block
3333
#
34-
require "libxml"
34+
require "libxml-ruby"
3535
warn "#{__FILE__}:#{__LINE__}: loaded libxml-ruby '#{LibXML::XML::VERSION}'"
3636
end
3737

0 commit comments

Comments
 (0)