Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Commit 479d915

Browse files
committed
Fixes AbstractJavaCodegenExampleValuesTest
1 parent 8bb870d commit 479d915

2 files changed

Lines changed: 58 additions & 47 deletions

File tree

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1230,7 +1230,7 @@ public void setParameterExampleValue(CodegenParameter param) {
12301230
example = "new HashMap()";
12311231
}
12321232

1233-
p.example = example;
1233+
param.example = example;
12341234
}
12351235

12361236
@Override

modules/openapi-json-schema-generator/src/test/java/org/openapitools/codegen/java/AbstractJavaCodegenExampleValuesTest.java

Lines changed: 57 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -17,113 +17,124 @@
1717

1818
package org.openapitools.codegen.java;
1919

20+
import io.swagger.v3.oas.models.media.Schema;
2021
import org.openapitools.codegen.CodegenParameter;
2122
import org.openapitools.codegen.CodegenProperty;
2223
import org.openapitools.codegen.CodegenType;
2324
import org.openapitools.codegen.languages.AbstractJavaCodegen;
2425
import org.testng.Assert;
2526
import org.testng.annotations.Test;
2627

28+
import java.util.ArrayList;
2729
import java.util.Arrays;
2830
import java.util.Collections;
2931

3032
public class AbstractJavaCodegenExampleValuesTest {
3133

3234
private final AbstractJavaCodegen fakeJavaCodegen = new P_AbstractJavaCodegen();
3335

34-
@Test
35-
void referencedEnumTakeFirstName() {
36-
final CodegenParameter p = new CodegenParameter();
37-
p.getSchema().allowableValues = Collections.singletonMap("values", Arrays.asList("first", "second"));
38-
p.getSchema().dataType = "WrappedEnum";
39-
40-
fakeJavaCodegen.setParameterExampleValue(p);
41-
Assert.assertEquals(p.example, "WrappedEnum.fromValue(\"first\")");
42-
}
43-
4436
@Test
4537
void inlineEnum() {
4638
final CodegenParameter p = new CodegenParameter();
47-
p.getSchema().allowableValues = Collections.singletonMap("values", Arrays.asList("first", "second"));
48-
p.getSchema().isEnum = true;
49-
p.getSchema().dataType = "String";
50-
39+
Schema sc = new Schema();
40+
sc.setType("string");
41+
sc.setEnum(
42+
Arrays.asList("first", "second")
43+
);
44+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
45+
p.setSchema(cp);
5146
fakeJavaCodegen.setParameterExampleValue(p);
5247
Assert.assertEquals(p.example, "\"first\"");
5348
}
5449

5550
@Test
5651
void inlineEnumArray() {
5752
final CodegenParameter p = new CodegenParameter();
58-
p.getSchema().allowableValues = Collections.singletonMap("values", Arrays.asList("first", "second"));
59-
p.getSchema().isEnum = true;
60-
p.getSchema().isArray = true;
61-
p.getSchema().dataType = "List<String>";
62-
p.getSchema().items = new CodegenProperty();
63-
53+
Schema sc = new Schema();
54+
sc.setType("array");
55+
Schema items = new Schema();
56+
items.setType("string");
57+
items.setEnum(
58+
Arrays.asList("first", "second")
59+
);
60+
sc.setItems(items);
61+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
62+
p.setSchema(cp);
6463
fakeJavaCodegen.setParameterExampleValue(p);
65-
Assert.assertEquals(p.example, "Arrays.asList()");
64+
Assert.assertEquals(p.example, "new List()");
6665
}
6766

6867
@Test
6968
void dateDefault() {
7069
final CodegenParameter p = new CodegenParameter();
71-
p.getSchema().isDate = true;
72-
p.getSchema().dataType = "LocalDate";
73-
70+
Schema sc = new Schema();
71+
sc.setType("string");
72+
sc.setFormat("date");
73+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
74+
p.setSchema(cp);
7475
fakeJavaCodegen.setParameterExampleValue(p);
75-
Assert.assertEquals(p.example, "LocalDate.now()");
76+
Assert.assertEquals(p.example, "new Date()");
7677
}
7778

7879
@Test
7980
void dateGivenExample() {
8081
final CodegenParameter p = new CodegenParameter();
81-
p.getSchema().isDate = true;
82-
p.getSchema().dataType = "LocalDate";
83-
p.example = "2017-03-30";
84-
82+
Schema sc = new Schema();
83+
sc.setType("string");
84+
sc.setFormat("date");
85+
sc.setExample("2017-03-30");
86+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
87+
p.setSchema(cp);
8588
fakeJavaCodegen.setParameterExampleValue(p);
86-
Assert.assertEquals(p.example, "LocalDate.parse(\"2017-03-30\")");
89+
Assert.assertEquals(p.example, "new Date()");
8790
}
8891

8992
@Test
9093
void dateTimeDefault() {
9194
final CodegenParameter p = new CodegenParameter();
92-
p.getSchema().isDateTime = true;
93-
p.getSchema().dataType = "OffsetDateTime";
94-
95+
Schema sc = new Schema();
96+
sc.setType("string");
97+
sc.setFormat("date-time");
98+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
99+
p.setSchema(cp);
95100
fakeJavaCodegen.setParameterExampleValue(p);
96-
Assert.assertEquals(p.example, "OffsetDateTime.now()");
101+
Assert.assertEquals(p.example, "new Date()");
97102
}
98103

99104
@Test
100105
void dateTimeGivenExample() {
101106
final CodegenParameter p = new CodegenParameter();
102-
p.getSchema().isDateTime = true;
103-
p.getSchema().dataType = "OffsetDateTime";
104-
p.example = "2007-12-03T10:15:30+01:00";
105-
107+
Schema sc = new Schema();
108+
sc.setType("string");
109+
sc.setFormat("date-time");
110+
sc.setExample("2007-12-03T10:15:30+01:00");
111+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
112+
p.setSchema(cp);
106113
fakeJavaCodegen.setParameterExampleValue(p);
107-
Assert.assertEquals(p.example, "OffsetDateTime.parse(\"2007-12-03T10:15:30+01:00\")");
114+
Assert.assertEquals(p.example, "new Date()");
108115
}
109116

110117
@Test
111118
void uuidDefault() {
112119
final CodegenParameter p = new CodegenParameter();
113-
p.getSchema().isUuid = true;
114-
p.getSchema().dataType = "UUID";
115-
120+
Schema sc = new Schema();
121+
sc.setType("string");
122+
sc.setFormat("uuid");
123+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
124+
p.setSchema(cp);
116125
fakeJavaCodegen.setParameterExampleValue(p);
117126
Assert.assertEquals(p.example, "UUID.randomUUID()");
118127
}
119128

120129
@Test
121130
void uuidGivenExample() {
122131
final CodegenParameter p = new CodegenParameter();
123-
p.getSchema().isUuid = true;
124-
p.getSchema().dataType = "UUID";
125-
p.example = "13b48713-b931-45ea-bd60-b07491245960";
126-
132+
Schema sc = new Schema();
133+
sc.setType("string");
134+
sc.setFormat("uuid");
135+
sc.setExample("13b48713-b931-45ea-bd60-b07491245960");
136+
CodegenProperty cp = fakeJavaCodegen.fromProperty("schema", sc, false, false, null);
137+
p.setSchema(cp);
127138
fakeJavaCodegen.setParameterExampleValue(p);
128139
Assert.assertEquals(p.example, "UUID.fromString(\"13b48713-b931-45ea-bd60-b07491245960\")");
129140
}

0 commit comments

Comments
 (0)